Fixes for core PR; add cancel split button #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imorland
approved these changes
Jul 14, 2022
davwheat
force-pushed
the
dw/fixes-and-cancel-btn
branch
2 times, most recently
from
15bedb2
to
aedf9db
Compare
davwheat
force-pushed
the
dw/fixes-and-cancel-btn
branch
from
aedf9db
to
0e52587
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Post-footeritem when no split in progress (needed for Hide post footer when empty flarum/framework#2926)appproperty called__fof_split, which contains info about any active splitSplitControllerinstance toapp.__fof_split$.show()on the split to button, setapp.__fof_split.splittingtotrueand trigger redrawSplitControllerReviewers should focus on
I feel like this is slightly hacky, but I honestly couldn't think of a better way to do it.
Screenshot
Ignore the
0in the video below. It's from a local change to core.fDSgLq4hOs.mp4
Confirmed**
composer test).