Skip to content
This repository has been archived by the owner on Nov 26, 2023. It is now read-only.

Hopefully fix ext not working (assuming subfolder setup) + some cleanup #18

Merged
merged 6 commits into from
Feb 7, 2022

Conversation

dsevillamartin
Copy link
Member

Fixes hopefully #17

Changes proposed in this pull request:

  • I'm assuming the ext did not work with subfolders due to the register path check
    • Please check whether it did/didn't work, and whether this PR fixes it if necessary
  • JS cleanup
    • Use Flarum prettier
    • Add Flarum tsconfig
    • Update to Webpack 5

Reviewers should focus on:

  • Mainly the register path thing on subfolder setups

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).

@ekumanov
Copy link

ekumanov commented Feb 7, 2022

Is there a way I can test this merge request on my forum before it is merged?

@dsevillamartin
Copy link
Member Author

@ekumanov Yep! You can run composer require fof/stopforumspam:dev-ds/fixes-cleanup.

@ekumanov
Copy link

ekumanov commented Feb 7, 2022

@datitisev thanks, just tested it and can confirm it finally works now, thank you! When you release it, how should I switch to the released version (from the dev branch, although they will be the same as content)?

@dsevillamartin
Copy link
Member Author

@ekumanov Looks like composer require fof/stopforumspam will upgrade from dev to stable. So you can run that when it's released - I'll ping you and let you know 🙂.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants