feat: Flag notifications #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OwenMelbz
reviewed
May 23, 2022
| $flag = $this->flag; | ||
|
|
||
| $notify = User::query() | ||
| ->where('users.id', '!=', $flag->actor->id) |
There was a problem hiding this comment.
Should this not be $flag->user ? rather than $flag->actor ?
The user() is the relationship, actor only happens to be there upon an authenticated request from the http kernel.
If this gets executed by a queue worker, the actor isn't populated, however user is as this is a defined relationship.
There was a problem hiding this comment.
That's a great spot! How did this ever work 🙈
There was a problem hiding this comment.
Oh wait this is new code, okay makes sense. Let's get it fixed @imorland can probably tag a release somewhere the coming days.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow subscriptions to new flags.
Whilst the
alertnotification is probably redundant, the email option could be useful for moderators who are not always online.