Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: User link Cannot use ::class with dynamic class name #28

Merged
merged 1 commit into from
Mar 15, 2023
Merged

fix: User link Cannot use ::class with dynamic class name #28

merged 1 commit into from
Mar 15, 2023

Conversation

eddiewebb
Copy link
Contributor

**Fixes #25 **

Changes proposed in this pull request:
Replaces the ::class with a get_class on the $blueprint->user

Reviewers should focus on:

Screenshot
Screenshot shows email dumped to logs is working after reigstration.
Screen Shot 2022-12-04 at 9 20 29 AM

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).

@imorland imorland changed the title Fixes issue #25 fix: User link Cannot use ::class with dynamic class name Mar 15, 2023
@imorland imorland merged commit a4c0e56 into FriendsOfFlarum:master Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luceos luceos luceos approved these changes

@imorland imorland imorland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

User link Cannot use ::class with dynamic class name
3 participants
@eddiewebb @luceos @imorland