Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent line break spam & better error handling #54

Merged
merged 3 commits into from
Oct 8, 2023
Merged

Prevent line break spam & better error handling #54

merged 3 commits into from
Oct 8, 2023

Conversation

dsevillamartin
Copy link
Member

Supersedes #52

Changes proposed in this pull request:

  • Trim 2+ line breaks to 2 max
  • Add setting to configure max # of lines visible
  • Improve error handling when user bio fails to save
    • If saving fails, user goes back to editing their bio
    • If failed when pressing enter to submit, will keep trying each time
    • If failed when blurring, will stop attempting if no changes are made and textarea loses focus again

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).

@dsevillamartin dsevillamartin merged commit 9092982 into master Oct 8, 2023
25 checks passed
@dsevillamartin dsevillamartin deleted the ds/prevent-line-break-spam branch October 8, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dsevillamartin