Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retain scroll, add buttons & edit in profile page only #58

Merged
merged 5 commits into from
Jun 29, 2024
Merged

Retain scroll, add buttons & edit in profile page only #58

merged 5 commits into from
Jun 29, 2024

Conversation

dsevillamartin
Copy link
Member

Changes proposed in this pull request:

  • Add "Save", "Cancel" buttons to editing mode to have clear actions instead of saving on blur or enter
  • Retain scroll & click positions when moving into editing mode
  • Only allow editing in profile page
    • You cannot edit in a discussion page anyways due to the SubtreeRetainer config, and this keeps the behavior consistent with Flarum core (eg. editing user avatar)

image
image

@dsevillamartin dsevillamartin merged commit eecaad9 into master Jun 29, 2024
28 checks passed
@dsevillamartin dsevillamartin deleted the ds/ux-improvements branch June 29, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dsevillamartin