Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ds/small fixes improvements #104

Merged
merged 6 commits into from
Sep 27, 2023
Merged

Ds/small fixes improvements #104

merged 6 commits into from
Sep 27, 2023

Conversation

dsevillamartin
Copy link
Member

Fixes #103
Fixes #69
Fixes #101

Changes proposed in this pull request:

  • Use flexbox & grid layouts for UserDirectoryPage nav at the top
    • Improved search input to allow clicking anywhere & has focus styles
    • Improved mobile layout
  • Add 'searchUsers' permission check & hide 'search all users' if not permitted
  • Add option to link group mentions to user directory page
  • Set title in UserDirectoryPage

Reviewers should focus on:
?

Screenshot
image
image

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).

@imorland imorland merged commit c2728e5 into master Sep 27, 2023
4 checks passed
@imorland imorland deleted the ds/small-fixes-improvements branch September 27, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants