Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multi-group search for more than 10 groups #105

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Fix multi-group search for more than 10 groups #105

merged 1 commit into from
Sep 27, 2023

Conversation

iPurpl3x
Copy link
Collaborator

Description

This PR fixes a major issue in the search field related to the Group Filter. Previously, selecting multiple groups in the search field would produce incorrect behavior when there are more than 10 groups. This PR rectifies that.

Reviewers should focus on:

  • The behavior of the search field when using the Group Filter. Please verify that the issue has been fixed, and no unintended side effects have been introduced.

Confirmed

  • Frontend changes: tested on a local Flarum installation.

@imorland imorland merged commit 34395c8 into FriendsOfFlarum:master Sep 27, 2023
2 checks passed
@imorland imorland deleted the fix/search-filed-ui branch September 27, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants