Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended search field #82

Merged
merged 5 commits into from
Dec 15, 2021
Merged

Extended search field #82

merged 5 commits into from
Dec 15, 2021

Conversation

iPurpl3x
Copy link
Collaborator

Changes proposed in this pull request:

Breaking:

  • The filter dropdown now does inner joins instead of outer joins when multiple groups are selected

New:

  • The Search Filed can now be used to filter users by selecting groups and more
  • This feature is extensible. Other extensions can register search types, by extending from forum/searchType/AbstractType.

Credits of for this change go mainly to @clarkwinkelmann who initially added this extended search filed to this extension one year ago! (see 9f3ed08)

Minor Changes:

  • Optimized logic of filter dropdown
  • The filter dropdown now changes the URL

Reviewers should focus on:
This is purely a front-end enhancement. Just check that the new feature works and the old filter dropdown isn't broken.

Screenshot

image

(Screenshot is from https://community.skillsnet.swiss, who is sponsoring this feature!)

Confirmed

  • Frontend changes: tested on a local Flarum installation.

@imorland imorland merged commit b798f21 into master Dec 15, 2021
@imorland imorland deleted the im/extendSearch branch December 15, 2021 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants