-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug Report: Chart Editor Has A Maximum Song Length of 25 Minutes and 21.742 Seconds #3070
Comments
Very interesting bug and precise boundary! Does changing the BPM (or any other song properties) affect this boundary? |
After applying the following changes, nothing changed with the boundary: setting the BPM to 50, 200, and 150, testing all of the available stages, and changing the note style to pixel notes. Something to be noted is that I did not attempt changing the 3 character options to see if those would cause a change in the boundary. So, while unlikely, it is possible that changing any of those things could cause the boundary to increase, resulting in the ability to make a chart longer than 25 minutes and 21.742 seconds. |
I tried to make a song with that same length and it glitched either way. Tried exporting with a different sample rate and it worked. |
After a bit of debugging I found out that the issue traces all the way around to these lines in OpenFL's sound backend And as I imagined it has to do with integer limitations. Just look at how the math goes 2.147.480.672 is pretty close to the 32-bit integer positive limit (2.147.483.647, just 2475 of difference) but still below it, so that's why it still works. Now I debugged the same song with a sample rate of 48,000 Hz |
Amazing detective work, Hyper! That pesky integer limit messes with everything! |
Issue Checklist
What platform are you using?
Itch.io (Downloadable Build) - Windows
If you are playing on a browser, which one are you using?
None
Version
0.4.1
Context (Provide images, videos, etc.)
The chart editor will not allow a song longer than 25 minutes and 21.742 seconds. Even one millisecond longer and the chart editor becomes very small (less than one measure) and you cannot add notes for the whole song. Attached are two photos, one of them is a song that is 25 minutes and 21.742 seconds. It looks like a normal chart would. The other is of a song that is 25 minutes and 21.743 seconds (only one millisecond longer). It does not look like a normal chart would. Also, the times on the bottom right and left of the chart are both negative and only a couple of minutes instead of the whole length.
![25m 21 742s](https://private-user-images.githubusercontent.com/176774876/352776315-d549b5d1-f737-4925-aa93-f610a4076fa5.JPG?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU5NzY0NTcsIm5iZiI6MTcyNTk3NjE1NywicGF0aCI6Ii8xNzY3NzQ4NzYvMzUyNzc2MzE1LWQ1NDliNWQxLWY3MzctNDkyNS1hYTkzLWY2MTBhNDA3NmZhNS5KUEc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwOTEwJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDkxMFQxMzQ5MTdaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1mYTY2N2YxNzU4YTg4ODIzYmQ4ODQ4MGYxODY2MjM0ODFmZTVjY2ZmNzQzNDQ1YzZhNTg0YTJhMTYzOTVlZjExJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.MBt85MuRomXaGmsKHzZsEaRVZaalToGD7iKz4pbKzs4)
![25m 21 743s](https://private-user-images.githubusercontent.com/176774876/352776375-2525c811-e7a5-4f1f-848c-77f4a8105e28.JPG?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU5NzY0NTcsIm5iZiI6MTcyNTk3NjE1NywicGF0aCI6Ii8xNzY3NzQ4NzYvMzUyNzc2Mzc1LTI1MjVjODExLWU3YTUtNGYxZi04NDhjLTc3ZjRhODEwNWUyOC5KUEc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwOTEwJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDkxMFQxMzQ5MTdaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0yOTcwODI0ODQ0MWRiMzgzZWY3OGM1NjI5YWQzNzRiODVmNmUxNTg1MDVmOGE1Njk0ZTI1ZWYwMjYwYjU4MTNjJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.5WdkfSsn7-JPIpF-RqNdewGRSaMz4VeSV-TmOm2rYgE)
Steps to reproduce (or crash logs, errors, etc.)
Go into chart editor. Select File -> New Chart. In "Create New" select any of the 3 options (the issue occurs regardless of which difficulty settings you choose). Click "Continue". Select a song that is longer than 25 minutes and 21.742 seconds and the chart editor will break. Select a song that is 25 minutes and 21.742 seconds or less and the chart editor will work as intended.
The text was updated successfully, but these errors were encountered: