[BUGFIX] Avoid integer overflow when calculating sound length #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented using WebAudio API targeting HTML5 and OpenAL targeting Windows & Neko
…ssion' into develop
Fast forward
Multiplying `data.length * 8` produces a high number, which in the case of very long audio files can exceed the integer limit. Multiplying by 8.0 coerces to float, allowing much higher values.
|
Since dev-funkin has more recent commits than develop it already has this fix. Looks like you're just gonna fast-forward dev-funkin into develop so would it be better to close this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issues
Fixes FunkinCrew/Funkin#3070
(who the heck would play a 25+ minute long song anyway?)Description
Important
This will also require bumping Funkin's hmm OpenFL commit hash to work
This is basically commit 7a2f328 cherry-picked from upstream, details on what this exactly fixes are better explained by the commit's description. But it would be ideal to upgrade Funkin's OpenFL instead, I think.