Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Open PauseSubState on PlayState Focus Loss #3004

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

CrusherNotDrip
Copy link

@CrusherNotDrip CrusherNotDrip commented Jul 11, 2024

This PR makes it so it opens the PauseSubState when the game loses focus on PlayState.

This is helpful in a scenario where before this pr, they might just mess up as they dive immediately right back into the game if they didn't pause already. After this pr, if the player unfocused the game, it will pause the game helping them prepare to hit their keys again and they don't funk up their current progress in the song.

@EliteMasterEric
Copy link
Member

Isn't this supposed to be OFF if Auto-Pause is disabled? I'd imagine that if Auto-Pause is off, the user probably, you know, wouldn't want the game to automatically pause.

Also I'm confused as to why your code wouldn't work in charting mode, you can still pause the game in the playtest.

@EliteMasterEric EliteMasterEric self-assigned this Jul 11, 2024
@EliteMasterEric EliteMasterEric added type: enhancement Provides an enhancement or new feature. status: needs revision Cannot be approved because it is awaiting some work by the contributor. medium A medium pull request with 100 or fewer changes labels Jul 11, 2024
@EliteMasterEric EliteMasterEric removed their assignment Jul 11, 2024
@CrusherNotDrip
Copy link
Author

Isn't this supposed to be OFF if Auto-Pause is disabled? I'd imagine that if Auto-Pause is off, the user probably, you know, wouldn't want the game to automatically pause.

You know what fair enough but even with it being turned on, the game only freezes on focus loss so should I just make this go only with the auto pause preference ON then? or would this PR just be a no go?

Also I'm confused as to why your code wouldn't work in charting mode, you can still pause the game in the playtest.

im confused too 😭😭😭

@EliteMasterEric EliteMasterEric deleted the branch FunkinCrew:develop July 12, 2024 01:00
@Cartridge-Man
Copy link

I feel like if this was changed to work only for auto pause, then this would work perfectly

@CrusherNotDrip
Copy link
Author

I feel like if this was changed to work only for auto pause, then this would work perfectly

i forgot about this pr so ima just do it rn

@Cartridge-Man
Copy link

lol nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium A medium pull request with 100 or fewer changes status: needs revision Cannot be approved because it is awaiting some work by the contributor. type: enhancement Provides an enhancement or new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants