-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENHANCEMENT] Open PauseSubState on PlayState Focus Loss #3004
base: develop
Are you sure you want to change the base?
[ENHANCEMENT] Open PauseSubState on PlayState Focus Loss #3004
Conversation
Isn't this supposed to be OFF if Auto-Pause is disabled? I'd imagine that if Auto-Pause is off, the user probably, you know, wouldn't want the game to automatically pause. Also I'm confused as to why your code wouldn't work in charting mode, you can still pause the game in the playtest. |
You know what fair enough but even with it being turned on, the game only freezes on focus loss so should I just make this go only with the auto pause preference ON then? or would this PR just be a no go?
im confused too 😭😭😭 |
I feel like if this was changed to work only for auto pause, then this would work perfectly |
i forgot about this pr so ima just do it rn |
…for chart editor (funky way but oh well)
lol nice |
This PR makes it so it opens the
PauseSubState
when the game loses focus onPlayState
.This is helpful in a scenario where before this pr, they might just mess up as they dive immediately right back into the game if they didn't pause already. After this pr, if the player unfocused the game, it will pause the game helping them prepare to hit their keys again and they don't funk up their current progress in the song.