[BUGFIX] Remove unnecessary player vocals muting

[gamerbross]

ghost missing muted the player vocals, theres no point

[tposejank]

this also broke songs with only bf vocal track merged.

[AbnormalPoof]

Hoping this gets merged since it gets very awkward on songs that do not have split vocals (Basically every mod)

ghost_miss_bug.mp4

[KutikiPlayz]

what if, instead of fully removing this, you just unmute the vocals when the opponent sings for songs that have the vocals in one file, like how the game used to work

[tposejank]

what if, instead of fully removing this, you just unmute the vocals when the opponent sings for songs that have the vocals in one file, like how the game used to work

See the problem with that is the game expects people use separate voice tracks as it's more convenient, and isn't likely they want ot do that instead of just easily not muting the bf vocal track when a ghost miss occurs.

[AbnormalPoof]

See the problem with that is the game expects people use separate voice tracks as it's more convenient

The game actually DOES look for Voices.ogg as a last resort. The vocal muting most likely wasn't accounted for that though, unfortunately.

[KutikiPlayz]

this is my point, I don't mean do it all the time I mean specifically if the vocals are combined
better yet, just put your combined vocals as the opponent vocals and leave the bf vocals empty or missing
solves the problem ez pz

[tposejank]

Indeed it does look, but it may soon feel like a deprecated feature

[Hundrec]

this is my point, I don't mean do it all the time I mean specifically if the vocals are combined

better yet, just put your combined vocals as the opponent vocals and leave the bf vocals empty or missing

solves the problem ez pz

#2837 reports that this doesn't solve the problem (unless you replace BF's vocals with silence)

[EliteMasterEric]

Getting this PR to work such that it functions if the player misses on a single vocal track would be great for people looking to port mods.

[tposejank]

Getting this PR to work such that it functions if the player misses on a single vocal track would be great for people looking to port mods.

FNF Porter reference!!!

[gamerbross]

Getting this PR to work such that it functions if the player misses on a single vocal track would be great for people looking to port mods.

I've been working on a true solution for that. I have 2 solution proposals:

• Unmute voices when the opponent hits a note (just when the game detects only player vocal track).
  Cons:

  • You will still hear the player voices in a duet part and will just sound with stutter.
  • Will keep the sound stutter in songs with a true player only vocals, like Camellia.

• (i think its the best) An internal timer in the VoiceGroup object that resets to 0 everytime the player misses, when the timer is done (duration will be hold note lenghth, or for single notes 0.5s) unmute the player vocal track.
  Pros:

  • Less stutter than the other solution in duet parts.
  • Lyrics parts without notes don't get muted, like TwiddleFinger. (most of the PRs I've done lately it's because I've been porting it lol)

Cons:

• uhh nothing i think

---

@EliteMasterEric plz i need your opinion on these so i can make a cool pr

[tposejank]

I dunnoooooo new property time??

[EliteMasterEric]

I've been thinking about it, and maybe vocal muting should just straight up be disabled if there is no opponent vocal track.

Pros:

• This ensures the opponent's voice is never muted even during duets.

Cons:

• The player not muting on hit is inconsistent with the normal behavior, but with only one vocal track something will have to be inconsistent from normal anyway.

[tposejank]

Exactly.