-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUGFIX] Remove unnecessary player vocals muting #3012
base: main
Are you sure you want to change the base?
[BUGFIX] Remove unnecessary player vocals muting #3012
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this also broke songs with only bf vocal track merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hoping this gets merged since it gets very awkward on songs that do not have split vocals (Basically every mod)
ghost_miss_bug.mp4
what if, instead of fully removing this, you just unmute the vocals when the opponent sings for songs that have the vocals in one file, like how the game used to work |
See the problem with that is the game expects people use separate voice tracks as it's more convenient, and isn't likely they want ot do that instead of just easily not muting the bf vocal track when a ghost miss occurs. |
this is my point, I don't mean do it all the time I mean specifically if the vocals are combined |
Indeed it does look, but it may soon feel like a deprecated feature |
#2837 reports that this doesn't solve the problem (unless you replace BF's vocals with silence) |
Getting this PR to work such that it functions if the player misses on a single vocal track would be great for people looking to port mods. |
FNF Porter reference!!! |
I've been working on a true solution for that. I have 2 solution proposals:
Cons:
@EliteMasterEric plz i need your opinion on these so i can make a cool pr |
I dunnoooooo new property time?? |
I've been thinking about it, and maybe vocal muting should just straight up be disabled if there is no opponent vocal track. Pros:
Cons:
|
Exactly. |
ghost missing muted the player vocals, theres no point