Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Custom pre-death music loop & animation behavior #3014

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

anysad
Copy link

@anysad anysad commented Jul 12, 2024

Briefly describe the issue(s) fixed.

  • This PR aims to add an event dedicated to adding custom logic before the music and animation starts. As one of the devs (probably EliteMasterEric himself) put it:
    TODO: Make the behavior for playing Jeff's voicelines generic or un-hardcoded.
    This will simplify the class and make it easier for mods to add death quotes.
  • By utilizing this new event, this PR also softcodes Jeff's voicelines (aka Tankman in week 7). Just because it's convenient.
  • And last but not least. eventn -> event 🙂

Include any relevant screenshots or videos.

  • Just to put it out here, this event uses two parameters. The first one is whether the game over music should play in the first place, and the second parameter is the volume of said game over music.
    image

@EliteMasterEric EliteMasterEric added status: pending triage The bug or PR has not been reviewed yet. type: enhancement Provides an enhancement or new feature. medium A medium pull request with 100 or fewer changes labels Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium A medium pull request with 100 or fewer changes status: pending triage The bug or PR has not been reviewed yet. type: enhancement Provides an enhancement or new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants