-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENHANCEMENT] Custom Popups and Countdowns #3020
base: develop
Are you sure you want to change the base?
Conversation
Cool stuff anysad! |
thank you, mister Hundrec 🫡 |
just saw that I accidentally made a copy of the |
Might review this and rework it myself later, but the way I originally architected this system, the plan was that custom popups and countdowns would be defined by the current note style. |
Your wish is my command. Starting to work on it. |
@EliteMasterEric I made it use the current note style, and if no assets were found for the specific note style, it reverts back to using the default assets. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could center the countdown to make it look cleaner, besides that this PR deserves to be merged!
Each note style defines a fallback note style, all assets should check if the specific note style has an asset, then check if the fallback has it, then check if ITS fallback has it, continuing until you reach a note style with no fallback. The default |
@EliteMasterEric Done.
countdown.mp4
popup.mp4 |
manipulating.with.assets.mp4
pixel.AND.funkin.mp4 |
Also, will have to cleanup the code tomorrow a little to remove the unnecessary |
As you suggested, I centered it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR 100% Merge deserved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is gonna be so helpful if this gets merged ngl
This code looks great overall and seems to not break anything. There are some tweaks I want to make (for example, there are a lot of merge conflicts with our internal branch) but I will make those changes myself. |
Briefly describe the issue(s) fixed.
(see video below)
(see video below)
This PR fixes theMoved to [BUGFIX] Fix Song Metadata Height funkin.assets#54Song Metadata
box in the chart editor, letting you finally choose notestyles easily.(see photo below)
Include any relevant screenshots or videos.
twinsomnia
notestyle (no assets) /twinsomnia-booger
notestyle (with assets)based.on.notestyle.mp4
fix.scaling.mp4