Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIXES CHARACTER PATH ONLY CHECKING IN SHARED #3035

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

7oltan
Copy link

@7oltan 7oltan commented Jul 16, 2024

so im trying to make it so it will load characters from a week dir but its not letting me so i checked and saw this was the problem so i fixed it :3

@moxie-coder
Copy link

I don't think this is a good idea since I don't think it checks in shared by default

@anysad
Copy link

anysad commented Jul 16, 2024

why not just place character assets in shared/images/characters?

@anysad
Copy link

anysad commented Jul 16, 2024

I don't think this is a good idea since I don't think it checks in shared by default

it doesn't check in shared by default, it initially checks in preload

@moxie-coder
Copy link

I don't think this is a good idea since I don't think it checks in shared by default

it doesn't check in shared by default, it initially checks in preload

I know, that's kinda why I think this might cause issues

@7oltan
Copy link
Author

7oltan commented Jul 16, 2024

I don't think this is a good idea since I don't think it checks in shared by default

it doesn't check in shared by default, it initially checks in preload

I know, that's kinda why I think this might cause issues

why tho?

@7oltan
Copy link
Author

7oltan commented Jul 16, 2024

why not just place character assets in shared/images/characters?

i want to add the characters in a week type dir to save memory and just to make images look cleaner

@EliteMasterEric EliteMasterEric added the status: pending triage The bug or PR has not been reviewed yet. label Jul 17, 2024
@mayo78
Copy link

mayo78 commented Jul 18, 2024

I don't think this is a good idea since I don't think it checks in shared by default

it doesn't check in shared by default, it initially checks in preload

I know, that's kinda why I think this might cause issues

how would it be an issue? it checks first for preload, then for the level path, and then shared

@EliteMasterEric EliteMasterEric added status: reviewing internally This PR is under internal review and quality assurance testing type: optimization Involves a performance issue or a bug which causes lag. and removed status: pending triage The bug or PR has not been reviewed yet. labels Jul 23, 2024
@EliteMasterEric EliteMasterEric self-assigned this Jul 23, 2024
@EliteMasterEric EliteMasterEric added the small A small pull request with 10 or fewer changes label Jul 23, 2024
@EliteMasterEric
Copy link
Member

Paths automatically checks which library has the file before using it, so this should be good.

I believe characters were originally IN the level folders before moving them out due to issues when characters were shared between levels.

@EliteMasterEric EliteMasterEric added status: accepted Approved for contribution. If it's not already merged, it may be merged on a private branch. and removed status: reviewing internally This PR is under internal review and quality assurance testing labels Jul 29, 2024
@EliteMasterEric EliteMasterEric added this to the 0.5.0 milestone Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small A small pull request with 10 or fewer changes status: accepted Approved for contribution. If it's not already merged, it may be merged on a private branch. type: optimization Involves a performance issue or a bug which causes lag.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants