-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use chart inst offset for song resync + other resync fixes #3058
base: develop
Are you sure you want to change the base?
Conversation
relevent -> relevant
Update ScriptEventType.hx
This finally fixes #2888. Yay! |
Doesn't #2706 already do the desync fix? |
I tried the pr and it doesn't fix the desync issue, this pr makes other changes in order to fix that |
LGTM |
Worked well for me when I tried it, and since it works for a bunch of other reviewers I'd say it's good. |
Any reasons the tracks are being paused though? You can just set the sound's time and move on |
You can't just set the sound's time and move on without pausing as that would cause issues getting both the instrumental and vocals synced. |
Pausing both tracks at the same time stops the time variable from increasing while you're setting it, making it easier to resync, and makes it more accurate. |
I was under the impression |
The time variable does change during the update function but it doesn't really increase if paused. |
resyncVocals() function in PlayState now makes use of instrumentalOffset.
This PR also halves the requirement for a resync, because 100ms is a big enough difference to greatly change timings in my personal opinion.
The resyncVocals() function now also resyncs the instrumental track the same way as the vocals.
Resyncing is checked every beat instead of every step.
This PR eliminates any and all resyncing issues players are plagued with, below is a before and after;
Before:
2024-07-23.19-06-07.mp4
After:
2024-07-23.19-08-21.mp4