-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENHANCEMENT] Link the official modding documentation in repository README #3082
base: main
Are you sure you want to change the base?
Conversation
I feel like Modding.md could also be updated |
You did the wrong thing. I was talking about the mods folder readme. There is a readme in the mods folder. This is for the REPOSITORY. Do not do this. This should not close my issue. I'm pretty sure the mods folder just shows up on release builds, so if the mods folder's README is copied from something in this repo, you should edit that instead. If not, this should not be merged because then it will close my issue. |
That is a really old file so I think they should get rid of it instead. The README in the mods folder is a better replacement and it is in all release builds. They could also just replace the contents with the mods folder's readme if they add my suggestion to add the link to the docs to that instead. |
You mean like the introMod/README.md file or the "do NOT readme.txt"? If the former these example mods don't even get copied to release builds due to a problem. Lines 90 to 97 in 9b483de
|
The mods folder has a readme separate from that one. Look inside it in a release build and you will see. I know what I'm talking about. |
|
It's alright, happens to the best of us lol. |
I think I just experienced brain damage, but thanks for the support! (This is a joke, I’m not actually trying to be mean, I mean, I might be, but idk!) |
I don't think you're joking. That was a LONG LONG stream of text with a lot of edits made. It's all good. You can see how much I edit stuff by clicking that "edited" dropdown. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this one is good actually
Does this PR close any issues? If so, link them below.
#3080
Briefly describe the issue(s) fixed.
Just adds a link to the book created by the official Funkin’ Crew to the repository’s README.