Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENTS/ADDITIONS]: Pause Menu Enhancements #3087

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

JVNpixels
Copy link

@JVNpixels JVNpixels commented Aug 2, 2024

Slight enhancements, corrections, and additions are added to the pause menu

!!! W.I.P !!!

This Pull Request / PR doesn't overhaul it entirely, just adds little changes

  • Botplay Text In The Pause Menu
  • Naughtyness Patch (NAUGHTYNESS = Blue Balls) (NO NAUGHTYNESS = Deaths)
  • Blue Balls Grammar Fixing
  • BotPlay Text POS Fix (if practice is disabled and only botplay, there will be a gap, so remove it.)

# Slight enhancements, corrections, and additions are added to the pause menu
## !!! W.I.P !!!
This Pull Request / PR doesn't overhaul it entirely, just adds little changes
@JVNpixels JVNpixels changed the title Pause Menu Enhancements [ENHANCEMENTS/ADDITIONS]: Pause Menu Enhancements Aug 2, 2024
hey guys, im silly osu fan girl or smth, i've been exposed for using botplay... well out and about now! DATTEBAYO!!!
Co-authored with KutikiPlayz.
@KutikiPlayz
there is hope ladies and gentlemen, wait who are ladies never heard of em?
@JVNpixels
Copy link
Author

@KutikiPlayz, sorry I couldn’t get to you sooner, I was gone for the majority of the day, I finally understand what this new code means, it took me a bit but i realized, and when writing this I realized you put it in the comment, I didn’t read the whole thing, but I added your feature and I will make another update to my feature as well with these new if else conditions.

Co-Authored with KutikiPlayz!
@KutikiPlayz

instead of it being a clunk and junk of one single line, i decided to use the other recommendation of @KutikiPlayz and split the tenary operator into 3 lines!
@EliteMasterEric EliteMasterEric added the status: pending triage The bug or PR has not been reviewed yet. label Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: pending triage The bug or PR has not been reviewed yet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants