Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT/BUGFIX] Bopper auto speed check + BPM Change song event type #3092

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

MidyGamy
Copy link

@MidyGamy MidyGamy commented Aug 5, 2024

This fixes the bopper desyncing from each other, imitating the
if(curBeat % 2 == 0) dad.dance();
from the 0.3.X of the game

@MidyGamy MidyGamy changed the title Bopper auto speed check [ENHANCEMENT/BUGFIX] Bopper auto speed check Aug 5, 2024
@EliteMasterEric EliteMasterEric added the status: pending triage The bug or PR has not been reviewed yet. label Aug 14, 2024
@MidyGamy
Copy link
Author

For the moment, I have to continue it...
It crashes with Week 7 and Weekend 1

@MidyGamy
Copy link
Author

MidyGamy commented Aug 20, 2024

submodules are pain

@MidyGamy MidyGamy marked this pull request as ready for review August 20, 2024 22:43
@MidyGamy MidyGamy changed the title [ENHANCEMENT/BUGFIX] Bopper auto speed check [ENHANCEMENT/BUGFIX] Bopper auto speed check + BPM Change song event type Aug 20, 2024
@MidyGamy
Copy link
Author

Now should work correctly

@MidyGamy MidyGamy requested a review from PurSnake August 20, 2024 23:42
@MidyGamy
Copy link
Author

Yeah, I just made a branch combining my 2 pull requests... I never thought that would work so well.

@MidyGamy
Copy link
Author

So yeah, 2 bug fixes in one:

  • the fact it plays too fast the idle twice (forced) after a sing pose
  • sometimes the idle plays on odd beats instead of even ones
    And it should find the optimal beat to dance on to be consistent if the idle last more than 2 beats

@MidyGamy
Copy link
Author

You should notice it here:
https://www.youtube.com/watch?v=o2e4R2bUNPk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: pending triage The bug or PR has not been reviewed yet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants