-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUGFIX] Player's left notes being selected when they shouldn't #3093
base: develop
Are you sure you want to change the base?
[BUGFIX] Player's left notes being selected when they shouldn't #3093
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank god for this
An amazingly simple fix! |
Just found a fix for this too. 2024-08-06.15-02-54.mp4 |
Perhaps selecting events by highlighting any region on the right should be a quality of life feature! As it stands, it's a little difficult to select only a subset of events without accidentally picking up the player's right arrows as well. |
Makes sense, I guess I'll only keep the fix for the left part. |
Does this PR close any issues? If so, link them below.
Briefly describe the issue(s) fixed.
When selecting any part to the left of the chart any left note in the Player's side that is in the vertical boundary of the selection box would be mistakenly selected. This is better demonstrated in the before/after video below.
Include any relevant screenshots or videos.
fnf-bug-before-after.mp4