Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cam rotation support #2

Draft
wants to merge 1 commit into
base: dev-6.0.0
Choose a base branch
from
Draft

Conversation

cyn0x8
Copy link

@cyn0x8 cyn0x8 commented Jun 17, 2024

implementation of world space camera rotation via a rotation property

2024-06-15.21-52-18.mp4

@Raltyro
Copy link

Raltyro commented Jul 5, 2024

Why hasn't this been in base flixel yet...

@ACrazyTown
Copy link

Why not PR this to the main flixel repository?

@cyn0x8
Copy link
Author

cyn0x8 commented Aug 25, 2024

Why not PR this to the main flixel repository?

i will! i just wanted it here first so it can get implemented ingame faster

@cyn0x8
Copy link
Author

cyn0x8 commented Aug 26, 2024

Why not PR this to the main flixel repository?

i will! i just wanted it here first so it can get implemented ingame faster

turns out they already have a better implementation planned for world-space rotation (though itll take time, on the 7.0.0 milestone)

should i close this pr or keep open? myself as well as some people i know have immediate use cases for this, so while a better implementation would be nice, itll probably be a long time for it to make it to flixel and then to this repo and then finally into the game

@cyn0x8 cyn0x8 marked this pull request as draft August 26, 2024 16:46
@AbnormalPoof
Copy link

AbnormalPoof commented Aug 28, 2024

I'd say keep it open if it's going to take a while (like a very long time) for it to be in base Flixel. FunkinCrew's flixel fork seems to be exclusively used on FNF, so having cam rotation specifically for FNF would be nice. The official implementation for camera rotation can also simply act as the replacement later down the line when it makes it into base Flixel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants