Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Week 7 Cutscenes no longer a video #32

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

CrusherNotDrip
Copy link

@CrusherNotDrip CrusherNotDrip commented Jun 18, 2024

What is this pull request?

This Pull Request redoes the Week 7 cutscenes but everything happens in-game instead of as a video.

Here is a video of them (It may look like the mp4 but even poorer quality (had to compress it) but it shows the countdown transition so u can still kinda see what its like in-game):

week7-realtime-cutscenes.mp4

Changelog:

Additions:

  • The cutscene music now has a metadata and conductor to go along with it which makes all boppers go along with the music until the actual song plays.
  • Atlases for the custom animations during the cutscenes. (Like Tankman talking and Pico killing the tankmen)
  • Girlfriend sparrow as FlxAnimate doesn't support effects apparently. (and my adobe would refuse to export it with the effect anyways)

Fixed:

  • Some offsets with some characters for their cutscene animations.

Deletions:

  • Videos are no longer used. Obviously.
  • The ability to skip the cutscenes. (As you can only do that with videos apparently.)

Some things to note:

Yeah I know some of these are probably gonna make this pr not get accepted but still worth noting in case you do accept it and wanna tweak some things in the future.

  • The camera zoom is still set to the original camera zoom as the video (This is only applied during the cutscene, it goes back to normal once its over.)
  • The cutscene metadata for Distorto and the Stress Cutscene may be incorrect. (For the artist I just put Kawai Sprite & for the bpm, I got someone to at least try and guess them. [@/gameboy1969 on Twitter])
  • I put this as a comment in the code already, but the stress cutscene isn't affected by the Naughtyness preference at all as I ran into an issue while testing it out.
  • One of the tank audience is hidden during the boyfriend holding girlfriend miss (Stress Cutscene) due to it's head clipping off, it is unhidden afterwards.

@AppleHair
Copy link

AppleHair commented Jun 18, 2024

This PR completes around 90% of the work on real-time week 7 cutscenes. It wouldn't be smart of the devs not to merge this, even if it doesn't get ALL the tiny details right.

@CyndaquilDAC
Copy link

unfortunately i doubt this will get merged just because of the effects issue. flxanimate just doesnt support that right now and i havent seen any strides taken to fix that by anyone so rn this seems like a no go

@CrusherNotDrip
Copy link
Author

hm I might just leave this as a draft then (I think you can do that) until its actually ready then.

@CrusherNotDrip CrusherNotDrip marked this pull request as draft June 18, 2024 22:31
@AbnormalPoof
Copy link

For the part in 0:56, have you considered making GF turning Demon into a spritesheet for that segment alone? FlxAnimate currently doesn't support filters, so the effect isn't there.

@CrusherNotDrip
Copy link
Author

CrusherNotDrip commented Jun 21, 2024

Updated PR so GF has the effect now
and gf turning is now a sparrow.

I'm gonna try and see if I can fix the bug with Naughtyness preference and Stress Cutscene audio and then open this pr again. (if I fail then I'm gonna open anyways)4

Also on a completely unrelated note I just beat my Week 7 highscore.

@CrusherNotDrip
Copy link
Author

I got lazy and never tried so ima just open this

@CrusherNotDrip CrusherNotDrip marked this pull request as ready for review June 28, 2024 00:21
@EliteMasterEric EliteMasterEric added status: reviewing internally Cannot be approved; under continuing review and quality assurance testing status: pending triage The bug or PR has not been reviewed yet. and removed status: reviewing internally Cannot be approved; under continuing review and quality assurance testing labels Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: pending triage The bug or PR has not been reviewed yet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants