Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Offset & Position Edits For Each Character #39

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Jestrox
Copy link

@Jestrox Jestrox commented Jun 26, 2024

Edited sing offsets for all characters (except "Blazin") to better flow with each other. Stopping their feet from sliding around when each animation is played.
[An improvement for general looks & gameplay]

Moved all characters so their feet are based in the same location. So all characters will stand in the same spot on a stage, rather than being in a different position depending on the character.
[An improvement for use in Freeplay & using characters in any stage]

NOTE { The images shown are of each character on a test stage where they are placed at [0, 0]. The red dot is exactly on [0, 0], while the red crosshair and white background are there to help position them. }

[Dad]

  • Based animations on shoe tips.
    op1

[GF + Car + Christmas + Tankmen]

  • Moved animations such as "sad", "drop70" & "duck" in line with the rest of the animations (mainly the idle).
  • Made sure all speakers in the exact same position. (This also applies to Pico Speaker)
  • Edited "GF.HXC" to { this.originalPosition.y = pos.y - (this.characterOrigin.y + 3) } to put her in the correct position during the Tutorial.
    gf1
    gf2
    gf3
    gf4
    gf5

[Spooky]

  • Based animations on Pump's left foot, including "cheer".
    op2

[Monster + Christmas]

  • Minor touch ups to foot locations, mainly basing them on the left foot.
  • Used screen shots to make sure both the normal and Christmas variants are exactly the same. In terms of stage position, animations & camera. (Minus Christmas wearing a hat)
    op3
    op4

[Pico Week 3]

  • Minor touch ups, made left & right closer to idle.
  • Tried to settle "singUp" & "singDown" between the two feet during idle.
    op5

[Mom Car]

  • Minor touch ups for foot locations.
  • Tried my best to set the right animation's left foot in a position that's similar to the idle, up & down.
  • Moved "cameraOffset" down to better view her on other stages.
    op6

[Parents Christmas]

  • Based animations on chair legs.
    op7

[Senpai + Angry]

  • Made animations pixel consistent.
  • Moved feet in "singDown" & "singLeft" to be inline with the idle.
  • Used screen shots to make sure both the normal and angry variants have the same stage location & cam positions. Like I did with Monster & GF.
    op8
    op9

[Spirit]

  • Made animations pixel consistent, based animations on top tip of trails for "singRight" & "singDown", then based "singUp" & "singLeft" on bottom tip.
    NOTE { Spirit used to be right on the centre point, but has been updated to float above it instead. }
    op10NEW

[GF Pixel]

  • Removed "singUp" from the json.
    gf6

[Tankman]

  • Minor touch ups to foot locations with "singUp", "singRight" & "singDown" having the same right heel position.
  • Moved "singLeft", "ugh" & "prettyGood" animations to be more exact on idle.
    op11

[Darnell]

  • Minor touch ups to foot locations on singing + laugh animations.
  • Based can animations on left foot.
  • Edited "darnell.XML" so the hold animations don't have his jacket laces and headphones moving.
    op12

[Nene]

  • Moved "idleKnife" by one pixel to better match other knife animations.
  • Moved "combo50" & "combo100" in line with the rest of the animations.
  • Minor touch ups to sitting locations for "laughCut" & "drop70".
  • Also edited "pico-playable.HXC" to make sure Nene is in the exact spot as she is on the speaker.
    NOTE { Speaker is sometimes weird (clips within itself), something that I noticed even before starting this project }
    gf7

[Blazin]

  • Pico & Darnell have also been moved to match the rest of the characters base positions.
    blaze1
    blaze2

However the camera position seems to be different in every stage.
And when testing normal Darnell in "Blazin", he was on the top left of the screen and continuously moving down each time he was meant to punch.
NOTE { I've moved the two to the correct positions in "Blazin", but I couldn't figure out how to move the game over sequence.
If you wish to not use the new Blazin positions but continue with Nene's. Make sure to copy the new GF location from "phillyBlazin.json" so she's in the correct location. }

[BF + Car + Christmas + Pixel + Holding GF + Pico Playable]

NOTE { I could not do the offsets for player characters yet due to the animation editor not having a player view like in Psych Engine. However I did move them to the same base position as the rest of the characters. }
bf1
bf2
bf3
bf4
bf5
bf6

Slight changes I made to the stages when putting characters back to their original positions.

[SpookyMansion]

  • Moved the opponent position lower to better match BF's.
  • Moved BF's cam offset up to hide edge of stage & better match Spooky's cam (The bottom is still shown in erect)
    stage2
    stage1

Original opponent positions with the new character location edits, Spooky [422, 811], Monster [432, 785].

[LimoRide]

  • Moved BF slightly down & Mom slightly up to better fit on limo.
  • Moved Mom's "cameraOffset" up to match her view before I changed her character json's cam offset.
    stagePOS
    stage3

Original character positions with the new character location edits, Mom [261.5, 853], BF [1217.5, 568].

[School]

  • Moved Senpai's position higher to better match BF's.
  • Moved BF's position slightly down so his's feet match with Senpai's.
  • Placed GF in-between where she was in the old "school" & the old "schoolEvil" layouts.
  • Added offset to scared dance for girls to match their normal dance.
    stage4
    stage5
    stage7

Original character positions with the new character location edits, Senpai[501, 918], GF [840, 854], BF [1133, 884].

[School Evil]

  • Change "cameraZoom" & character position values to that of the normal school for consistency.
    stage6NEW
    stage8NEW

Original character positions with the new character location edits, Spirit [334, 872], GF [840, 754], BF [1133, 884].

[Philly Blazin]

In case you want the new GF/Nene position value only [1427, 1095].

Examples of what can now be done in Freeplay.
example1
example2
example3
example4
example5

…r & moved all characters so their feet are based in the same location

[Dad]
Based animations on shoe end points.

[GF + Car + Christmas + Tankmen]
Moved animations such as sad, drop70 & duck in line with the rest of the animations (mainly the idle).
Made sure they are all in the same position. (This also applies to Pico Speaker)
Edited "GF.HXC" to { this.originalPosition.y = pos.y - (this.characterOrigin.y + 3)
} to put her in the correct position during the Tutorial.

[Spooky]
Based animations on left foot, including cheer.

[Monster + Christmas]
Minor touch ups to foot locations, mainly basing them on the left foot. Used screen shots to make sure both the normal and Christmas variants are are in exactly the same positions. In terms of stage position, animations & camera.

[Pico Week 3)
Minor touch ups, made left & right closer to idle. Tried to settle up & down between the two feet during idle.

[Mom] (Car)
Minor touch ups for foot locations. Tried my best to set the right animation's left foot in a position that's similar to the idle, up & down.

[Parents Christmas]
Based animations on chair legs.

[Senpai + Angry]
Made animations pixel consistent, moved feet to be inline with the idle. Used screen shots to make sure they there both the same, like I did with Monster.

[Spirit]
Made animations pixel consistent, based animations on top tip of trails for right & down, then based up & left on bottom tip.

[GF Pixel]
Removed "singUp" from the json.

[Tankman]
Minor touch ups to foot locations with up, right & down having the same right heel position. Moved ugh and pretty good animations to be more exact on idle.

[Darnell]
Minor touch ups to foot locations on singing + laugh animations, based can animations on left foot.
Edited XML file so hold animations don't have jacket laces and headphones moving.

[Nene]
Moved "idleKnife" by one pixel to better match other knife animations
Moved "combo50" & "combo100" in line with the rest of the animations
Minor touch ups to sitting locations for laughCut & drop70
Also edited Pico player hxl to make sure Nene is in the exact spot as she is on the speaker.
NOTE { Speaker sometimes weird (clips within itself) }

[Blazin]
Pico & Darnell have also been moved to match the rest of the characters base positions.
However the camera position seems to be different in every stage. And normal Darnell was on the top left of the screen and continuously moving down when using him in "Blazin".
NOTE {I've moved the two to the correct positions in "Blazin", but I couldn't figure out how to move the game over sequence. If you wish to not use the new Blazin positions but continue with Nene's. Make sure to copy the new GF location within the "phillyBlazin" json so she's in the correct location.}

{I could not do player characters yet due to the animation editor not having a player view}

Slight changes to stages when putting characters back to their original positions.

[SpookyMansion]
Moved the opponent position lower to better match BF's.
Moved BF's cam offset up to hide edge of stage & better match Spooky's cam (The bottom is still shown in erect)

LimoRide
Moved BF slightly down & Mom slightly up to better fit on limo.

School
Moved Senpai position higher to better match BF.
Added offset to scared dance for girls to match their normal dance.

School Evil
Change camera Zoom & position values that of the normal school for consistency.
@Jestrox
Copy link
Author

Jestrox commented Jun 26, 2024

Sorry that I can't really show the animation offsets.
That's something that may need to be tested in game. :/

@Hundrec
Copy link

Hundrec commented Jun 26, 2024

You've done us a great service 🫡

Copy link

@trayfellow trayfellow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Goated pr rly useful especially for future-proofing Player Pico so less work needs to be done for his remixes

Copy link

@doggogit doggogit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really, really solid PR.

This is just futureproofing whatever mixes come next from the Crew.

Good shit!

Copy link

@MaybeMaru MaybeMaru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotta love the polish

@nebulazorua
Copy link

goated

@EliteMasterEric EliteMasterEric added status: reviewing internally Cannot be approved; under continuing review and quality assurance testing status: pending triage The bug or PR has not been reviewed yet. and removed status: reviewing internally Cannot be approved; under continuing review and quality assurance testing labels Jul 9, 2024
[Spirit]
Set Idle offset to 0, matching the rest of the cast.
Adjusted the other singing offsets  to match the idle. (All are now closer to [0, 0], except for singDOWN due to it's first frame)
Moved singLEFT down & singRIGHT left by one pixel to better match each other's plus the idle's faces. (Character pixel not position)
Moved singDOWN a bit lower to differentiate it more from the idle.
Moved the character a bit up, so Spirit is floating.
Added a small camera offset so the evil tree is visible in base "throns".

[Tankman]
Moved singRIGHT a bit to the left to stop it from sliding so much. Also making the bottom of the right foot more consistent.
@trayfellow
Copy link

trayfellow commented Jul 22, 2024

Tried testing this out for myself, i found a few characters that might need to be looked into again, maybe these require direct stage edits?

screenshot-2024-07-22-13-49-54
(Senpai is moved down way too much)
screenshot-2024-07-22-13-51-02
(Mom isnt standing in the right place of the car)
screenshot-2024-07-22-13-51-33
(Nene is floating on the regular Weekend1 Stage)
screenshot-2024-07-22-13-52-13
(Pico and Darnell nowhere to be seen in Blazin)
screenshot-2024-07-22-14-47-25
(GF is slightly below BF making BF look a bit floaty)

Added an alternate Darnell json where singDOWN is set in between the left and right foot in his other animations. Instead of being based on his left.
@Jestrox
Copy link
Author

Jestrox commented Jul 22, 2024

@trayfellow
Sorry, forgot to upload them.
I already done the stage edits, I just forgot to add them in.

@Jestrox Jestrox changed the title Offset & Position Edits For Each Character [ENHANCEMENT/CLEANUP] Offset & Position Edits For Each Character Jul 24, 2024
@Jestrox Jestrox changed the title [ENHANCEMENT/CLEANUP] Offset & Position Edits For Each Character [ENHANCEMENT] Offset & Position Edits For Each Character Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: pending triage The bug or PR has not been reviewed yet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants