New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENHANCEMENT] More Note Splash data customization #41

Open

CrusherNotDrip wants to merge 1 commit into FunkinCrew:main from CrusherNotDrip:notestyle-splash-data

CrusherNotDrip commented Jun 28, 2024 •

edited

Loading

THIS PULL REQUEST ALSO REQUIRES FunkinCrew/Funkin#2929 TO BE PUSHED!

What is this PR?

This pull request adds onto the note splash data and adds more customization to them!

This adds/now supports:

assetPath (String)
scale (Float)
offsets (Array (Float))
isPixel (Bool)
data/splash1Left (String)
data/splash2Left (String)
data/splash1Down (String)
data/splash2Down (String)
data/splash1Up (String)
data/splash2Up (String)
data/splash1Right (String)
data/splash2Right (String)

Known Issues:

Honestly the only one I know of is that if any data/splashVarientDir doesn't exist, it won't call the fallback one. If a note splash is disabled though it won't be a problem.


          More customizable note splash data

d4c9366

CrusherNotDrip mentioned this pull request

[ENHANCEMENT] More Note Splash data customization FunkinCrew/Funkin#2929

Open

EliteMasterEric added status: reviewing internally status: pending triage and removed status: reviewing internally labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: pending triage