Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gad 4 final --> latest_staging #1557

Merged
merged 23 commits into from
Apr 24, 2024
Merged

Gad 4 final --> latest_staging #1557

merged 23 commits into from
Apr 24, 2024

Conversation

prajjwalkapoor
Copy link

Issue that this pull request solves

Closes: # (issue number)

Proposed changes

Brief description of what is fixed or changed

Types of changes

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please describe):

Checklist

Put an x in the boxes that apply

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have created new branch for this pull request
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • My changes does not break the current system and it passes all the current test cases.

Screenshots

Please attach the screenshots of the changes made in case of change in user interface

Other information

Any other information that is important to this pull request

@prajjwalkapoor
Copy link
Author

@anudeeps0306 @itsspriyansh before merging please inform deployment team to install a new package that is added on requirements.txt file.

@VarunGitGood
Copy link

@theoden42 please check if correctly resolved

@theoden42
Copy link

LGTM! Merge conflicts are resolved correctly and all the changes, as expected, are in application:filetracking only.

@Priyansh61 Priyansh61 merged commit fb8c35b into latest_staging Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants