Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP goes async #452

Closed
wants to merge 30 commits into from
Closed

PHP goes async #452

wants to merge 30 commits into from

Conversation

GermanCoding
Copy link
Collaborator

No description provided.

@GermanCoding
Copy link
Collaborator Author

Forget to document this yesterday, the following things are still TODO in this PR:

  • protocol tests need to be updated
  • Expose the async implementations in public APIs
  • Fix failing test, check if new tests are needed
  • Some smaller TODOs listed in code
  • Consider reordering the arguments in Vaas class constructor as per linter suggestion (this PR already contains breaking changes)
  • Document implicitly thrown exceptions (VaasServerException, VaasClientException)

Philip Stadermann and others added 28 commits June 28, 2024 09:19
Start VaasWebSocket
88c3fcc
async test.php
756ee57
composer.json
b5b3c23
@lennartdohmann
WIP async
1daf88d
Deferred VerdictResponses
1be858c
@lennartdohmann
WIP async
7d421ce
Set sessionId before send request
109061f
@GermanCoding
Fix overwrite of uuid
89f75cb
@GermanCoding
Add async ForSha256
a8494a4
100TimesEicar
5a0a7f9
@GermanCoding
Fix ForFile
6ab01f2
@GermanCoding
Add AMP HttpClient
1fec342
onClose
dbe564d
@GermanCoding
Fix ForStream
6f0f98f
@GermanCoding
Fix ForStream tests
fad7baf
@GermanCoding
Fix ForUrl
846d5cb
@GermanCoding
Update tests
1f30c61
@GermanCoding
Add error handling for async
de21ff3
@GermanCoding
Cleanup all
2fc5d76
@GermanCoding
Temporarily disable ProtocolTests
7067893
@GermanCoding
Adjust examples for changed API flow
c866684
@GermanCoding
Remove debug logging
b7b6ec1
@GermanCoding
Remove even more debug logging
115d718
@GermanCoding
tmp debug failing test
010179f
@GermanCoding
Revert "tmp debug failing test"
f3e44ed 
This reverts commit 5e75ee4.
Remove unused files, VerdictResponse needs kind (for testing), extrac…
a547ef5 
…t testSetUp
WIP
31c00e0
VaasWebsocketTest: First test works!
6a2ad71
@unglaublicherdude
Copy link
Member

This #592 should do everything, this PR wanted to do

@GermanCoding GermanCoding deleted the php/async branch September 5, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GermanCoding @unglaublicherdude @lennartdohmann