Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust/better verdict #485

Merged
merged 6 commits into from
Aug 26, 2024
Merged

Rust/better verdict #485

merged 6 commits into from
Aug 26, 2024

Conversation

secana
Copy link
Member

@secana secana commented Jun 20, 2024

This PR changes the Rust SDK in such a way, that on "Malicious" and "Pup" a detection name is always provided. In the case that a detection hits the blacklist cloud and no detection name is given. Generic.Malware or Generic.Pup is returned.

It fixes an issue with wrong naming of the option to use the cloud as well.

@secana
Copy link
Member Author

secana commented Jun 20, 2024

Alternative Idee: Anstatt pro SDK eine Generic Detection rauszugeben, können wir das auch im Backend lösen und da immer einen Namen mitgeben. Das wäre dann einfacher über die anderen SDKs zu skalieren.

Philip Stadermann and others added 6 commits August 26, 2024 09:39
Copy link
Member Author

@secana secana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@pstadermann pstadermann merged commit e2b883c into main Aug 26, 2024
1 check passed
@pstadermann pstadermann deleted the rust/better-verdict branch August 26, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants