Php connection gets lost when idle after connect #544
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unglaublicherdude
force-pushed
the
php-connection-gets-lost-when-idle-after-connect
branch
from
dd63418
to
62916ee
Compare
unglaublicherdude
requested review from
pstadermann,
GermanCoding,
doxthree and
lennartdohmann
|
Ok. This is the first version, where all tests pass. |
lennartdohmann
approved these changes
Aug 2, 2024
unglaublicherdude
force-pushed
the
php-connection-gets-lost-when-idle-after-connect
branch
from
4f50139
to
c802a9f
Compare
|
With the update to "amphp/file": "3.1.1" this can now be reviewed. |
|
The failing run is the Delete old container images and I am not sure, why that runs anyway within this pr. |
unglaublicherdude
force-pushed
the
php-connection-gets-lost-when-idle-after-connect
branch
2 times, most recently
from
c802a9f
to
60113cc
Compare
|
Ok. I fixed the delete container images run but I am still not sure, why it runs in this PR (and other PRs aswell) |
|
I still see one major issue. Illuminate/Container does only support PHP >= 8.2. So I will have to downgrade it to a version that does still support 8.1 |
|
my fault. illuminate/containers is not used and was only in my composer.lock file |
…so the loop isn't running beyond the lifetime of the VaasConnection
…active connection
unglaublicherdude
force-pushed
the
php-connection-gets-lost-when-idle-after-connect
branch
from
60113cc
to
649eb2e
Compare
|
replaced by #592 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not complete yet. Missing is the Exceptions throw in the EventLoop while no request is running.