Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New function : display server time #8

Closed
wants to merge 3 commits into from

Conversation

zeno0207
Copy link

display server time on the scoreboard
Source code referred : https://github.com/CAICCU/AccessCai/blob/main/Classes/KFScoreBoard.uc#L268

@GenZmeY
Copy link
Owner

GenZmeY commented Jul 26, 2024

Thanks for the PR

The scoreboard already has server time (bottom right corner of the panel, under the wave number). Judging by the code, you propose to add the local time of the player in the space between the number of players and the server time.

I have to reject (or at least postpone) this addition:

  1. I don't know how it looks (it would be nice if you attached a screenshot), but it seems to me that the readability of the panel will suffer if there are two times next to each other without any signatures or markers

  2. The current version of the scoreborad looks correct in all resolutions, nowhere does the text overlap each other. I have a concern that this may become a problem if the bottom line is filled with text more densely. This PR definitely needs to be tested in other resolutions (I don't want to do this, tbh)

If you do not agree with my arguments, you can always publish your fork, I specifically chose a license that allows other people to develop and distribute their modifications

Copy link
Author

@zeno0207 zeno0207 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

encrease HeaderWidthRatio

@zeno0207
Copy link
Author

zeno0207 commented Aug 6, 2024

Sorry,I am busy recently.Here are screenshots in all languages.(https://photos.app.goo.gl/vTb3cen6rycBJGMw7)
As you said,the text overlap each other in specific language such as russian.So I try to encrease the width of header from 0.3 to 0.4.(https://photos.app.goo.gl/M24VGWx3dBydHoQX8)
I also test in different resolutions.(https://photos.app.goo.gl/PAkuRxJrtMFgBwM59)

@GenZmeY
Copy link
Owner

GenZmeY commented Aug 10, 2024

Thanks for the screenshots, I took a look

I know you put some time and effort into this, but I like the current look of the scoreboard better than the one with the date and time on it, so I guess I'll leave it as is. I hope you're not too upset.

I think you should post your version in the workshop if you want this feature

@GenZmeY GenZmeY closed this Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants