fix(Composer): memory leak

when there's attachments uploaded, the dialog should be unowned
GeopJr · May 15, 2023 · 028b743 · 028b743
1 parent b7a6245
commit 028b743
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/Dialogs/Composer/AttachmentsPage.vala b/src/Dialogs/Composer/AttachmentsPage.vala
@@ -147,6 +147,7 @@ public class Tuba.AttachmentsPage : ComposerPage {
 	Widget on_create_list_item (Object item) {
 		var attachment = item as API.Attachment;
 		var attachment_widget = new AttachmentsPageAttachment(attachment.id, attachment.source_file, dialog, attachment);
+
 		attachment_widget.remove_from_model.connect(() => {
 			uint indx;
 			var found = attachments.find (item, out indx);

diff --git a/src/Dialogs/Composer/AttachmentsPageAttachment.vala b/src/Dialogs/Composer/AttachmentsPageAttachment.vala
@@ -4,7 +4,7 @@ public class Tuba.AttachmentsPageAttachment : Widgets.Attachment.Item {
 	protected File? attachment_file;
 	protected string? alt_text { get; set; default = null; }
 	private const int ALT_MAX_CHARS = 1500;
-	private Dialogs.Compose compose_dialog;
+	private unowned Dialogs.Compose compose_dialog;
 	protected string id;
 
     public AttachmentsPageAttachment (string attachment_id, File? file, Dialogs.Compose dialog, API.Attachment? t_entity){