fix(mv): set use-graphics-offload to false #1049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is likely caused by https://gitlab.gnome.org/GNOME/gtk/-/issues/6824 and also affects other apps. Hopefully offload can be turned on again once things have been further stabilized. |
rmader
added a commit
to rmader/Tuba
that referenced
this pull request
Jul 8, 2024
This reverts commit 050f49c.
rmader
added a commit
to rmader/Tuba
that referenced
this pull request
Jul 15, 2024
The previously observed crashes were most likely all cases of a wrong assert in the GTK offload code that affected multiple apps, fixed in https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/7407 Thus turn on offloading again. This reverts commit 050f49c.
rmader
added a commit
to rmader/Tuba
that referenced
this pull request
Jul 17, 2024
This reverts commit 050f49c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #1025 #1048
Graphics offload is awesome but the random segfaults under some hardware are just so out of my control that I'd rather disable it for now.
Initially, the issue was the loading stack, but even after removing that, it still crashes on other people's hardware (it fixed it for me).
It's just not worth it. I can't even create a reproducer easily.