Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension v2.3.0 becomes unresponsive #152

Closed
fschwaiger opened this issue Dec 15, 2021 · 8 comments · Fixed by #154 or #174
Closed

Extension v2.3.0 becomes unresponsive #152

fschwaiger opened this issue Dec 15, 2021 · 8 comments · Fixed by #154 or #174

Comments

@fschwaiger
Copy link

[2021-12-15 13:06:33.799] [renderer8] [warning] UNRESPONSIVE extension host, 'Gimly81.matlab' took 98% of 3079.676ms, saved PROFILE here: 'file:///var/folders/vt/l5v0pvrx21s0r239h0zylz2r0000gn/T/exthost-8a6262.cpuprofile' 
[2021-12-15 13:07:13.004] [renderer8] [warning] UNRESPONSIVE extension host, 'Gimly81.matlab' took 63% of 7642.598ms, saved PROFILE here: 'file:///var/folders/vt/l5v0pvrx21s0r239h0zylz2r0000gn/T/exthost-4b14e9.cpuprofile' 

Here is the cpu profile:
exthost-8a6262.cpuprofile.zip

This did not occur until a few days ago, so I suspect a recent change, which could be v2.3.0.

@ghost
Copy link

ghost commented Dec 15, 2021

What's concerning here is that the slowdown is actually being caused by the new syntax selector parser based on Atom. This was actually proposed for VS Code in microsoft/vscode-textmate#52 and I was investigating having this parser work in WASM over at peggyjs/peggy#222 but I cannot promise anything other than reverting that huge upgrade in scope power.

This is a significant setback and I'm disappointed to see it happen :(

@ghost
Copy link

ghost commented Dec 15, 2021

Okay actually its the parser as written by the MS Atom team that is slow on low-end CPUs in anything other than WASM.

@ghost
Copy link

ghost commented Dec 21, 2021

Added caching instead of the Rust thing, it worked! Fix soon:tm:

@fschwaiger
Copy link
Author

Thank you!

@ghost
Copy link

ghost commented Dec 21, 2021

Actually do you have NPM on your computer? You could:

  1. Go back to 2.3.0 for the extension version.
  2. Open ~/.vscode/extensions/gimly81.matlab-2.3.0 in VS Code
  3. Run npm install vscode-textmate-languageservice@latest in the terminal.

And see if the CPU issue is resolved?

@fschwaiger
Copy link
Author

Did as you asked; for now it looks fine.

@ghost
Copy link

ghost commented Dec 24, 2021

Update to 2.3.1 to resolve this!

@zm-cttae-archive
Copy link
Contributor

zm-cttae-archive commented Jan 27, 2023

I will be posting a postmortem for the performance issues from my library in #142.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants