-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump vscode-textmate-languageservice from 0.2.1 to 1.1.0 #174
Conversation
Since `getCoreNodeModule` was removed, the bundler works again :)
Testing: extension is fully tested (
|
Also remove all Node requires before the return. This means we can make the extension web ready
This is awesome! Big question: will @Gimly merge this or not in the future? Can I try this out on my PC already? |
$ cd ~/.vscode/extensions/gimly81.matlab-2.*
$ npm i [email protected] |
Shoot... you will have to clone this out,
|
…code-matlab into feat-browser-support
Huge thanks!! |
Did you upgrade via |
Hack to fix
|
Sorry for the late reply. Thanks a lot for the comments! |
I am downloading a fresh purchased copy of Matlab to debug today |
Thanks! Probably, the issue is at my end. How can I remove Xavier Hahn's Matlab extension completely and try a fresh start? |
|
Confirmed web support via manual test (v1.75.1).
We now have web support! Better than Anycode 🎁❣ |
@jiecui go to github.dev/jiecui/mpact - please install |
Nice! |
I have not been able to get this working for vscode on windows, seems like I have the same issue as @jiecui based on his screenshot. Building and installing the package from the cloned repo doesn't seem to work, using the version in the vscode extension Marketplace works but lags too much to be usable. |
Riiight.. you've got to do EDIT: I updated the comment w/ instructions for local fix - #174 (comment). @Gimly you'll need to do |
Thanks, everything is working now. Great job making this extension usable! |
This is a full rewrite of the library that kills all tech debt, perf issues, and also adds browser support.
All providers exit within 100ms except for the definition provider which takes 1200ms. Not perfect but we've cut overheads by 1-2 orders of magnitude!
3 running theories for improvements.. mainly putting a stack variable for variable-property text merging in the tokenizer, & coalescing output data further to kill any overhead.
Not sure we are at the finish line here, but this will close a bunch of issues for sure.
These issues had regression test cases built to test them.. definitely killed these bugs 😄
If the changelogs interest you...
1.0.0-rc-1
and1.0.0-rc-2