Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

151 add one hot enconding #224

Merged
merged 6 commits into from
Nov 16, 2023
Merged

151 add one hot enconding #224

merged 6 commits into from
Nov 16, 2023

Conversation

nmaarnio
Copy link
Collaborator

@nmaarnio nmaarnio commented Nov 8, 2023

No description provided.

@nmaarnio nmaarnio linked an issue Nov 8, 2023 that may be closed by this pull request
Add one-hot encoding #151
Closed
@nmaarnio nmaarnio requested a review from Mtk112 November 8, 2023 13:01
msorvoja
msorvoja requested changes Nov 16, 2023
View reviewed changes
Copy link
Collaborator

@msorvoja msorvoja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I left some comments about parameter naming and default values. Also, I noticed that the function doesn't ignore argument for columns with NumPy array but raises InvalidColumnException.

eis_toolkit/transformations/one_hot_encoding.py Outdated Show resolved Hide resolved
eis_toolkit/transformations/one_hot_encoding.py Outdated Show resolved Hide resolved
eis_toolkit/transformations/one_hot_encoding.py Outdated Show resolved Hide resolved
msorvoja
msorvoja approved these changes Nov 16, 2023
View reviewed changes
Copy link
Collaborator

@msorvoja msorvoja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nmaarnio nmaarnio merged commit 0b610fc into master Nov 16, 2023
3 of 4 checks passed
@nmaarnio nmaarnio deleted the 151-add-one-hot-enconding branch February 19, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msorvoja msorvoja msorvoja approved these changes

@Mtk112 Mtk112 Awaiting requested review from Mtk112

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add one-hot encoding
2 participants
@nmaarnio @msorvoja