-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some miscellaneous ci and documentation additions #256
Some miscellaneous ci and documentation additions #256
Conversation
Switched to correct classifiers in pyproject.toml, they are not free-form. Removed requirements.txt as it is not needed alongside poetry. Removed setup.py as it was unused.
Runs pytest and mkdocs within the built container.
With the __main__.py file, eis_toolkit can be called with: python3 -m eis_toolkit --help
Hey, I think these look great improvements at a glance. Shoot when with a review request when you're ready! |
I will do some minor changes still, like making a new Dockerfile instead of messing up the old so if someone is using it they can continue. Also sorry about making formatting changes to the documentation, they are a bit annoying to review but changes to contents itself are minor. There mostly were some old instructions on how to develop etc. that I changed to reflect the current guidance. I will also make a comment here with a list of the actual changes I made. |
Reverted the changes to the original Dockerfile so if someone is using it, it still works as expected.
Changes:
These should be the most major changes. Ready for review. As said before, some changes are subjective and anything can be reverted. Just wanted to show the changes that I would personally make. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think all of the modifications/additions are good, and can't find any issues. So, ready to merge for my part! But since you updated GH actions, I wonder if we should enable the macos-latest
test as part of this PR and see if it works now? I disabled it previously because it suddenly started failing everytime, and didn't really look into the matter
|
Hey, went through the package for the purposes of general build file and documentation cleaning. Currently a draft until I have tested the new CI additions. None of the changes are required and some are subjective changes so if something should be kept as is (like keeping
requirements.txt
), just let me know and I will revert the change here.