Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

266 improve pca tool #269

Merged
merged 10 commits into from
Jan 4, 2024
Merged

266 improve pca tool #269

merged 10 commits into from
Jan 4, 2024

Conversation

nmaarnio
Copy link
Collaborator

@nmaarnio nmaarnio commented Jan 2, 2024

Following modifications were made:

  • Remove raster input
  • Modify docstring to be more descriptive
  • Change nodata handling: User can choose to remove completely or replace (with column/band mean)
  • Remove automatically creating pairplot
  • Add columns parameter to subset input DF columns for processing
  • Adjust tests

@nmaarnio nmaarnio linked an issue Jan 2, 2024 that may be closed by this pull request
5 tasks
@nmaarnio nmaarnio requested a review from Mtk112 January 2, 2024 14:02
Copy link
Contributor

@Mtk112 Mtk112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, left a few small suggestions.

eis_toolkit/exploratory_analyses/pca.py Outdated Show resolved Hide resolved
eis_toolkit/exploratory_analyses/pca.py Outdated Show resolved Hide resolved
eis_toolkit/exploratory_analyses/pca.py Show resolved Hide resolved
Copy link
Contributor

@Mtk112 Mtk112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now!

@nmaarnio nmaarnio merged commit 5a27864 into master Jan 4, 2024
6 checks passed
@nmaarnio nmaarnio deleted the 266-improve-pca-tool branch January 4, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve PCA tool
2 participants