Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor clean-up #295

Merged
merged 19 commits into from
Jan 23, 2024
Merged

Minor clean-up #295

merged 19 commits into from
Jan 23, 2024

Conversation

em-t
Copy link
Collaborator

@em-t em-t commented Jan 19, 2024

Minor code clean-up:

  • add Raises-section to docstrings where it was missing
  • remove unused exception class definitions
  • import only relevant exceptions
  • rename a handful of test files that were using a different naming convention than most of the test files
  • plus other very minor clean-up

@em-t em-t requested a review from nmaarnio January 19, 2024 09:41
Copy link
Collaborator

@nmaarnio nmaarnio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wrote a few single comments but otherwise this is a good clean-up and harmonization, thanks! We started importing exceptions by importing the whole module somewhere along the way, but now I cannot really see any reason to prefer that over the individual imports. So let's do the change you suggested here 👍

eis_toolkit/raster_processing/unique_combinations.py Outdated Show resolved Hide resolved
eis_toolkit/training_data_tools/class_balancing.py Outdated Show resolved Hide resolved
@nmaarnio nmaarnio merged commit 195e2f0 into master Jan 23, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants