Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

344 ML model and CLI improvements #345

Merged
merged 8 commits into from
Mar 12, 2024
Merged

Conversation

nmaarnio
Copy link
Collaborator

@nmaarnio nmaarnio commented Mar 8, 2024

This PR concerns both CLI and ML tools.

CLI

  • Added enum getter/unpacker (was required for list enums to be interpreted correctly but applied to all to be sure)
  • All CLI functions with enum parameters use the above getter
  • Harmonized how enum parameters are defined for CLI functions (now always Annotated[EnumParameterType, typer.Option(case_sensitive=False) = EnumParameterType.some_default_value)

ML modeling

  • Added links to Sklearn and Keras docs where relevant
  • Added criterion parameter to Random Forest models
  • Added raster grid check to ML model data preparation and renamed training rasters -> feature rasters for clarity (since some call labels as training data)

@nmaarnio nmaarnio linked an issue Mar 8, 2024 that may be closed by this pull request
Copy link
Contributor

@RichardScottOZ RichardScottOZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, sensible renaming.

@nmaarnio nmaarnio marked this pull request as ready for review March 11, 2024 06:52
Copy link
Contributor

@Mtk112 Mtk112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@nmaarnio nmaarnio merged commit fb3cf80 into master Mar 12, 2024
6 checks passed
@nmaarnio nmaarnio deleted the 344-ml-model-adjustments branch March 12, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ML model adjustments
3 participants