Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 1.7.1 to Support for large meshes #8

Closed
inkydragon opened this issue Aug 31, 2019 · 4 comments
Closed

Update to 1.7.1 to Support for large meshes #8

inkydragon opened this issue Aug 31, 2019 · 4 comments

Comments

@inkydragon
Copy link

ref: ImDrawList: Support for large meshes (64k+ vertices) with 16-bits indices · Issue #2591 · ocornut/imgui

When I'm trying to draw some Fractals, It's easy to touch this limit.

@Gnimuc
Copy link
Owner

Gnimuc commented Aug 31, 2019

Hi, do you wanna make a PR? It should be as simple as to upgrade CImGuiBuilder to 1.71 and then regenerate wrappers using Clang.jl. I don't have time to do this until Sep. 15.(sorry, I'm quite addicted to WoW Classic.)

@Gnimuc Gnimuc closed this as completed in 7ce0c88 Sep 23, 2019
@Gnimuc
Copy link
Owner

Gnimuc commented Sep 23, 2019

Hi @inkydragon, I just pushed 1.72b to master. Sorry for the postpone, it took me one more week to level up my priest to 60. :P

@inkydragon
Copy link
Author

There must be something wrong. When VtxBuffer.Size > 2^16, imgui still crashed. (use CImGui v1.72.0)

Assertion failed!

Program: C:\Users\woclass\AppData\Local\Julia-1.0.4\bin\julia.exe
File: /workspace/srcdir/cimgui/imgui/imgui.cpp, Line4030

Expression: draw_list->_VtxCurrentIdx < (1<<16) && "Too many vertices in ImDrawList using 6-bit indices. Read comment above"

image

Julia test code: Jui.jl/LargeMeshTest.jl

imgui test code: examples/example_glfw_opengl3 @ 1.72b + code snippet Issue #2591

@Gnimuc
Copy link
Owner

Gnimuc commented Oct 8, 2019

Oops, I forgot to update the backend, could you give #12 a try? @inkydragon

@Gnimuc Gnimuc reopened this Oct 8, 2019
@Gnimuc Gnimuc closed this as completed in 848d107 Oct 13, 2019
Gnimuc added a commit that referenced this issue May 23, 2020
JamesWrigley pushed a commit that referenced this issue Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants