Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add photo discovery sample built with Flutter, Vertex AI Search, and Reasoning Engine #779

Open
wants to merge 31 commits into
base: main
Choose a base branch
from

Conversation

khanhnwin
Copy link

Description

Adding the sample app built for I/O 2024 session with @kazunori279: Build generative AI agents with Vertex AI Agent Builder and Flutter

Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Follow the CONTRIBUTING Guide.
  • You are listed as the author in your notebook or README file.
    • Your account is listed in CODEOWNERS for the file(s).
  • Make your Pull Request title in the https://www.conventionalcommits.org/ specification.
  • Ensure the tests and linter pass (Run nox -s format from the repository root to format).
  • Appropriate docs were updated (if necessary)

@khanhnwin khanhnwin requested a review from a team as a code owner June 13, 2024 17:56
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 13, 2024

This comment has been minimized.

@khanhnwin
Copy link
Author

CC @koverholt! First time opening a PR for this repo, so please let me know if anything needs fixing. Thank you!

This comment has been minimized.

@koverholt koverholt self-requested a review June 13, 2024 19:06
@koverholt
Copy link
Member

Thanks for your contribution here! I'll review now and post feedback shortly. But this looks like a great example and companion code for your existing talk! 🙏

@koverholt koverholt changed the title Add photo discovery sample built with Vertex Agent Builder & Flutter feat: Add photo discovery sample built with Vertex Agent Builder & Flutter Jun 13, 2024
@koverholt koverholt changed the title feat: Add photo discovery sample built with Vertex Agent Builder & Flutter feat: Add photo discovery sample built with Flutter, Vertex AI Search, and Reasoning Engine Jun 13, 2024
Copy link
Member

@koverholt koverholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing this example as sample code for your session. It's a great example use case + use of Flutter that I love to see added to this repo! Let me know if I can help clarify any of the comments / feedback.

gemini/sample-apps/photo-discovery/README.md Show resolved Hide resolved
gemini/sample-apps/photo-discovery/README.md Outdated Show resolved Hide resolved
gemini/sample-apps/photo-discovery/README.md Outdated Show resolved Hide resolved
gemini/sample-apps/photo-discovery/README.md Outdated Show resolved Hide resolved
gemini/sample-apps/photo-discovery/README.md Outdated Show resolved Hide resolved
gemini/sample-apps/photo-discovery/README.md Show resolved Hide resolved
gemini/sample-apps/photo-discovery/README.md Outdated Show resolved Hide resolved
gemini/sample-apps/photo-discovery/README.md Show resolved Hide resolved

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@khanhnwin
Copy link
Author

Accept your suggestions @holtskinner! Thanks so much for the review!

@kazunori279 There's a few comments remaining from Kris for Vertex Agent side of things. Once you've resolved those, I think we're good to land!

@holtskinner holtskinner added owlbot:run Add this label to trigger the Owlbot post processor. and removed owlbot:run Add this label to trigger the Owlbot post processor. labels Jul 1, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 1, 2024
@github-actions github-actions bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 1, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 1, 2024
@github-actions github-actions bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 1, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 1, 2024
@github-actions github-actions bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 1, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 1, 2024
Fixed the notebook as per comments by Kris.
@github-actions github-actions bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 4, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 4, 2024

This comment has been minimized.

@github-actions github-actions bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 4, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 4, 2024
Copy link

github-actions bot commented Jul 4, 2024

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

Unrecognized words (34)
Autechre
Benno
Bettes
Borthwick
Envane
Gameplay
Glickman
Joji
Kaufmanns
Knopf
Lego
Mamah
Mosher
MSCHF
nmade
nmilitary
Oberst
Olgivanna
Omnibox
pantarba
pastiched
Phaidon
pietra
powerups
Rizzoli
Sestero
Simpsons
Sketchfab
Storrer
Tadao
Tafel
Topolino
Trapp
Vandamm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants