Skip to content

Commit

Permalink
fix: support NUMBER with no precision/scale (#572)
Browse files Browse the repository at this point in the history
  • Loading branch information
nehanene15 committed Aug 30, 2022
1 parent dcb9224 commit 03219ba
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions third_party/ibis/ibis_oracle/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,8 @@ def sa_oracle_LONG(_, satype, nullable=True):

@dt.dtype.register(OracleDialect_cx_oracle, sa.dialects.oracle.NUMBER)
def sa_oracle_NUMBER(_, satype, nullable=True):
if not satype.precision and not satype.scale:
return dt.Decimal(38, 0, nullable=nullable)
return dt.Decimal(satype.precision, satype.scale, nullable=nullable)


Expand Down

0 comments on commit 03219ba

Please sign in to comment.