fix: ensure all statuses are success or fail, particularly after _joi…

…n_pivots (#329) (#370)
GoogleCloudPlatform · Feb 18, 2022 · 310747d · 310747d
1 parent a9720c2
commit 310747d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/data_validation/combiner.py b/data_validation/combiner.py
@@ -90,6 +90,7 @@ def generate_report(
         print(documented.compile())
 
     result_df = client.execute(documented)
+    result_df.status.fillna("fail", inplace=True)
 
     return result_df
 

diff --git a/tests/unit/test_combiner.py b/tests/unit/test_combiner.py
@@ -538,7 +538,7 @@ def test_generate_report_without_group_by(
                     "difference": [-1.0, -1.0, _NAN, _NAN, _NAN, _NAN],
                     "pct_difference": [-50.0, -25.0, _NAN, _NAN, _NAN, _NAN],
                     "pct_threshold": [25.0, 25.0, _NAN, _NAN, _NAN, _NAN],
-                    "status": ["fail", "success", _NAN, _NAN, _NAN, _NAN],
+                    "status": ["fail", "success", "fail", "fail", "fail", "fail"],
                     "labels": [[("name", "group_label")]] * 6,
                 }
             ),