Skip to content

Commit

Permalink
feat: Allow user to specify a format for stdout, linting fix (#242)
Browse files Browse the repository at this point in the history
  • Loading branch information
Yogesh Tewari committed Jul 30, 2021
1 parent 1259529 commit 5707b3d
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions tests/system/data_sources/test_bigquery.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@

import pytest

from data_validation import cli_tools, consts, data_validation
from data_validation import __main__ as main
from data_validation import cli_tools, consts, data_validation

BQ_CONN = {"source_type": "BigQuery", "project_id": os.environ["PROJECT_ID"]}
CONFIG_COUNT_VALID = {
Expand Down Expand Up @@ -202,8 +202,7 @@ def test_count_validator():
assert float(max_birth_year_value) > 0
assert float(min_birth_year_value) > 0
assert (
df["source_agg_value"].astype(float).sum()
== df["target_agg_value"].astype(float).sum()
df["source_agg_value"].astype(float).sum() == df["target_agg_value"].astype(float).sum()
)


Expand Down Expand Up @@ -282,7 +281,7 @@ def _remove_bq_conn():


def test_unsupported_result_format():
with pytest.raises(ValueError) as exp:
with pytest.raises(ValueError):
validator = data_validation.DataValidation(CONFIG_GROUPED_COUNT_VALID, format="foobar", verbose=True)
df = validator.execute()
rows = list(df[df["validation_name"] == "count"].iterrows())
Expand Down

0 comments on commit 5707b3d

Please sign in to comment.