feat: Allow user to specify a format for stdout, added for other test…

… cases (#242)
GoogleCloudPlatform · Jul 30, 2021 · 76fbea5 · 76fbea5
1 parent cc384f1
commit 76fbea5
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 7 deletions.
diff --git a/tests/system/data_sources/test_mysql.py b/tests/system/data_sources/test_mysql.py
@@ -52,7 +52,7 @@
 def test_mysql_count_invalid_host():
     try:
         data_validator = data_validation.DataValidation(
-            CONFIG_COUNT_VALID, verbose=False,
+            CONFIG_COUNT_VALID, format="json", verbose=False,
         )
         df = data_validator.execute()
         assert df["source_agg_value"][0] == df["target_agg_value"][0]

diff --git a/tests/system/data_sources/test_postgres.py b/tests/system/data_sources/test_postgres.py
@@ -76,6 +76,6 @@ def test_postgres_count():
         ],
     }
 
-    data_validator = data_validation.DataValidation(config_count_valid, verbose=False,)
+    data_validator = data_validation.DataValidation(config_count_valid, format="json", verbose=False,)
     df = data_validator.execute()
     assert df["source_agg_value"][0] == df["target_agg_value"][0]
diff --git a/tests/system/data_sources/test_spanner.py b/tests/system/data_sources/test_spanner.py
@@ -159,7 +159,7 @@ def grouped_config(spanner_connection_config, database_id):
 
 
 def test_count_validator(count_config):
-    validator = data_validation.DataValidation(count_config, verbose=True)
+    validator = data_validation.DataValidation(count_config, format="json", verbose=True)
     df = validator.execute()
 
     count_value = df[df["validation_name"] == "count"]["source_agg_value"].values[0]
@@ -186,7 +186,7 @@ def test_count_validator(count_config):
 
 
 def test_grouped_count_validator(grouped_config):
-    validator = data_validation.DataValidation(grouped_config, verbose=True)
+    validator = data_validation.DataValidation(grouped_config, format="json", verbose=True)
     df = validator.execute()
     rows = list(df[df["validation_name"] == "count"].iterrows())
 

diff --git a/tests/system/data_sources/test_sql_server.py b/tests/system/data_sources/test_sql_server.py
@@ -76,6 +76,6 @@ def test_sql_server_count():
         ],
     }
 
-    data_validator = data_validation.DataValidation(config_count_valid, verbose=False,)
+    data_validator = data_validation.DataValidation(config_count_valid, format="json", verbose=False,)
     df = data_validator.execute()
     assert df["source_agg_value"][0] == df["target_agg_value"][0]
diff --git a/tests/system/data_sources/test_teradata.py b/tests/system/data_sources/test_teradata.py
@@ -37,7 +37,7 @@
 
 def create_validator(builder):
     return data_validation.DataValidation(
-        TERADATA_CONFIG, builder=builder, result_handler=None, verbose=False
+        TERADATA_CONFIG, builder=builder, result_handler=None, format="json", verbose=False
     )
 
 

diff --git a/tests/unit/test_schema_validation.py b/tests/unit/test_schema_validation.py
@@ -185,7 +185,7 @@ def test_execute(module_under_test, fs):
     )
     _create_table_file(TARGET_TABLE_FILE_PATH, _get_fake_json_data(target_data))
 
-    dv_client = data_validation.DataValidation(SAMPLE_SCHEMA_CONFIG, verbose=True)
+    dv_client = data_validation.DataValidation(SAMPLE_SCHEMA_CONFIG, format="json", verbose=True)
     result_df = dv_client.schema_validator.execute()
     failures = result_df[result_df["status"].str.contains("Fail")]