Merge branch 'develop' into issue50-group-by-nan

GoogleCloudPlatform · Aug 18, 2020 · 97c5b03 · 97c5b03
2 parents df6bfc0 + af78ba3
commit 97c5b03
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 0 deletions.
diff --git a/data_validation/data_validation.py b/data_validation/data_validation.py
@@ -18,6 +18,7 @@
 
 import google.oauth2.service_account
 from ibis.bigquery.client import BigQueryClient
+from ibis.impala.client import ImpalaClient
 import ibis.pandas
 from ibis.sql.mysql.client import MySQLClient
 from ibis.sql.postgres.client import PostgreSQLClient
@@ -41,6 +42,7 @@
 
 CLIENT_LOOKUP = {
     "BigQuery": BigQueryClient,
+    "Impala": ImpalaClient,
     "MySQL": MySQLClient,
     "Postgres": PostgreSQLClient,
     "Teradata": TeradataClient,

diff --git a/requirements.txt b/requirements.txt
@@ -1,6 +1,7 @@
 dataclasses==0.6
 google-api-python-client==1.10.0
 ibis-framework==1.3.0
+impyla==0.16.2
 sqlalchemy==1.3.18
 pymysql==0.10.0
 psycopg2-binary==2.8.5

diff --git a/third_party/ibis/ibis_addon/operations.py b/third_party/ibis/ibis_addon/operations.py
@@ -27,6 +27,7 @@
 
 from ibis.expr import datatypes
 from ibis.expr.operations import Comparison
+from ibis.impala.compiler import ImpalaExprTranslator
 
 
 class RawSQL(Comparison):
@@ -45,6 +46,7 @@ def format_raw_sql(translator, expr):
 
 
 ibis.bigquery.compiler.BigQueryExprTranslator._registry[RawSQL] = format_raw_sql
+ImpalaExprTranslator._registry[RawSQL] = format_raw_sql
 try:
     # Try to add Teradata and pass if error (not imported)
     from third_party.ibis.ibis_teradata.compiler import TeradataExprTranslator