Skip to content

Commit

Permalink
fix: issue-256-bug fixes to generate docker file (#531)
Browse files Browse the repository at this point in the history
  • Loading branch information
sramsrinivasan committed Jul 1, 2022
1 parent 181b865 commit adc528e
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 5 deletions.
8 changes: 8 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,15 @@ docs/_build
bigquery/docs/generated

# Virtual environment
.env
.venv
env/
venv/
rel_venv/
ENV/
env.bak/
venv.bak/

coverage.xml

# System test environment variables.
Expand Down
6 changes: 3 additions & 3 deletions samples/docker/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
FROM python:3.7.0-slim
FROM python:3.9.0-slim
ARG _APP_VERSION
COPY google_pso_data_validator-${_APP_VERSION}-py3-none-any.whl .
COPY google_pso_data_validator-${_APP_VERSION}-py2.py3-none-any.whl .
RUN apt-get update \
&& apt-get install gcc -y \
&& apt-get clean
RUN pip install --upgrade pip
RUN pip install google_pso_data_validator-${_APP_VERSION}-py3-none-any.whl
RUN pip install google_pso_data_validator-${_APP_VERSION}-py2.py3-none-any.whl
ENTRYPOINT ["python","-m","data_validation"]
4 changes: 2 additions & 2 deletions samples/docker/build_docker.sh
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,6 @@ cd ../../
python setup.py register sdist bdist_wheel

cd samples/docker
cp ../../dist/google_pso_data_validator-${PACKAGE_VERSION}-py3-none-any.whl .
cp ../../dist/google_pso_data_validator-${PACKAGE_VERSION}-py2.py3-none-any.whl .
docker build -t data_validation:$PACKAGE_VERSION --build-arg _APP_VERSION=$PACKAGE_VERSION .
rm google_pso_data_validator-${PACKAGE_VERSION}-py3-none-any.whl
rm google_pso_data_validator-${PACKAGE_VERSION}-py2.py3-none-any.whl

0 comments on commit adc528e

Please sign in to comment.