Ibis Addons to third party (#61)

* move ibis addons back to thrid party now that it works * fix import * fix import
GoogleCloudPlatform · Jul 22, 2020 · bcb8270 · bcb8270
1 parent 6fc20a3
commit bcb8270
Show file tree

Hide file tree

Showing 6 changed files with 4 additions and 5 deletions.
diff --git a/README.md b/README.md
@@ -211,7 +211,7 @@ If you want to add an Ibis Data Source which exists, but was not yet supported i
     - Import the extened Client for the given source (ie. from ibis.sql.mysql.client import MySQLClient).
     - Add the "<RefName>": Client to the global CLIENT_LOOKUP dictionary.
 
-2. In ibis_addon/operations.py
+2. In third_partty/ibis/ibis_addon/operations.py
     - Add the RawSQL operator to the data source registry (for custom filter support).
 
 3. You are done, you can reference the data source via the config.

diff --git a/data_validation/query_builder/query_builder.py b/data_validation/query_builder/query_builder.py
@@ -13,7 +13,7 @@
 # limitations under the License.
 
 import ibis
-from ibis_addon import operations
+from third_party.ibis.ibis_addon import operations
 
 
 class AggregateField(object):

diff --git a/setup.py b/setup.py
@@ -31,7 +31,6 @@
     "data_validation",
     "data_validation.query_builder",
     "data_validation.result_handlers",
-    "ibis_addon",
 ]
 packages += [
     "third_party.ibis.{}".format(path)

diff --git a/tests/unit/test_ibis_operations.py b/tests/unit/test_ibis_operations.py
@@ -16,7 +16,7 @@
 import pytest
 import ibis.pandas
 
-from ibis_addon import operations
+from third_party.ibis.ibis_addon import operations
 
 
 TABLE_DF = pandas.DataFrame([{"column": "value"}])
@@ -26,7 +26,7 @@
 
 @pytest.fixture
 def module_under_test():
-    from ibis_addon import operations
+    from third_party.ibis.ibis_addon import operations
 
     return operations
 

diff --git a/ibis_addon/__init__.py → third_party/ibis/ibis_addon/__init__.py b/ibis_addon/__init__.py → third_party/ibis/ibis_addon/__init__.py
diff --git a/ibis_addon/operations.py → third_party/ibis/ibis_addon/operations.py b/ibis_addon/operations.py → third_party/ibis/ibis_addon/operations.py