Skip to content

Commit

Permalink
remove redundant test
Browse files Browse the repository at this point in the history
  • Loading branch information
tswast committed Jul 23, 2020
1 parent 5db76e0 commit d09c6bc
Showing 1 changed file with 0 additions and 66 deletions.
66 changes: 0 additions & 66 deletions tests/system/result_handlers/test_bigquery.py
Original file line number Diff line number Diff line change
Expand Up @@ -139,69 +139,3 @@ def test_execute_with_nan(bigquery_client, bigquery_dataset_id):
result = get_dataframe(bigquery_client, table_id)
pandas.testing.assert_frame_equal(result, df)
bigquery_client.delete_table(table_id)


def test_execute_with_none(bigquery_client, bigquery_dataset_id):
table_id = f"{bigquery_dataset_id}.test_execute_with_none"
object_under_test = get_handler(bigquery_client, table_id)
create_bigquery_results_table(bigquery_client, table_id)
end = get_now()
start = end - datetime.timedelta(minutes=1)
df = pandas.DataFrame(
{
"run_id": ["grouped-test"] * 6,
"start_time": [start] * 6,
"end_time": [end] * 6,
"source_table_name": [
"test_source",
"test_source",
None,
None,
"test_source",
"test_source",
],
"source_column_name": [
"source_column",
"source_column",
None,
None,
"source_column",
"source_column",
],
"target_table_name": [
"test_target",
"test_target",
"test_target",
"test_target",
None,
None,
],
"target_column_name": [
"target_column",
"target_column",
"target_column",
"target_column",
None,
None,
],
"validation_type": ["GroupedColumn"] * 6,
"aggregation_type": ["count"] * 6,
"validation_name": ["count"] * 6,
"source_agg_value": ["2", "4", None, None, "6", "8"],
"target_agg_value": ["1", "3", "5", "7", "8", "9"],
"group_by_columns": [
'{"grp_a": "a", "grp_i": "0"}',
'{"grp_a": "a", "grp_i": "1"}',
'{"grp_a": "b", "grp_i": "0"}',
'{"grp_a": "b", "grp_i": "1"}',
'{"grp_a": "c", "grp_i": "0"}',
'{"grp_a": "c", "grp_i": "1"}',
],
"difference": [-1.0, -1.0, None, None, None, None],
"pct_difference": [-50.0, -25.0, None, None, None, None],
}
)
object_under_test.execute(None, df)
result = get_dataframe(bigquery_client, table_id)
pandas.testing.assert_frame_equal(result, df)
bigquery_client.delete_table(table_id)

0 comments on commit d09c6bc

Please sign in to comment.