Skip to content

Commit

Permalink
docs: score-cutoff changed to 1 (#779)
Browse files Browse the repository at this point in the history
* score-cutoff changed

* docs: score-cutoff changed
  • Loading branch information
rishabkhawad committed Mar 31, 2023
1 parent ddac942 commit d3aabca
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
5 changes: 2 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -456,13 +456,12 @@ target. The find-tables tool:
- Finally, it prints a JSON list of tables which can be a reference for the
validation run config.

Note that our score cutoff default is a 0.8, which was manually tested to be an
accurate value. If no matches occur, reduce this value.
Note that our score cutoff default is 1. If no matches occur, reduce this value as deemed necessary.

```
data-validation find-tables --source-conn source --target-conn target \
--allowed-schemas pso_data_validator \
--score-cutoff 0.8
--score-cutoff 1
```

### Using Beta CLI Features
Expand Down
2 changes: 1 addition & 1 deletion data_validation/__main__.py
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,7 @@ def get_table_map(client, allowed_schemas=None):

def find_tables_using_string_matching(args):
"""Return JSON String with matched tables for use in validations."""
score_cutoff = args.score_cutoff or 0.8
score_cutoff = args.score_cutoff or 1

mgr = state_manager.StateManager()
source_client = clients.get_data_client(mgr.get_connection_config(args.source_conn))
Expand Down

0 comments on commit d3aabca

Please sign in to comment.